[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 6 16:56:06 PST 2017

clayborg added a comment.

Jim Ingham said (in email):

> I disagree.  The different processes are at this point more about transport than about the platform details.  That indicates to me that it's more likely that different process implementations will have different ways of implementing signal filtering, but the input of which signals will be filtered will be the same.  Plus for each process the place where you would implement turning on and changing the filtering are the same.  So it makes more sense to have the part that says "go do this filtering" all be in common code, and the particular plugins implement how to do this.

That is fine. Seems like the UnixSignals class should be coordinating this instead of doing it manually in the process? Seems like the UnixSignals class should have guts here and call through to the Process::UpdateAutomaticSignalFiltering() only if needed?


More information about the lldb-commits mailing list