[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

Eugene Zemtsov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 6 15:50:09 PST 2017


eugene marked 3 inline comments as done.
eugene added a comment.

Addressing review comments.



================
Comment at: unittests/Signals/UnixSignalsTest.cpp:43
+
+#define ASSERT_EQ_ARRAYS(expected, observed)                                   \
+  AssertEqArrays((expected), (observed), __FILE__, __LINE__);
----------------
labath wrote:
> This (and the function) should probably have an EXPECT_.. prefix instead, as it does not abort the evaluation of the function it is in (like other ASSERT_*** macros).
This function calls ASSERT_EQ so it does abort evaluation.


https://reviews.llvm.org/D30520





More information about the lldb-commits mailing list