[Lldb-commits] [PATCH] D30624: Remove all of LLDB's custom filesystem statting code.

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 6 07:54:34 PST 2017

I put the using only if I have to type the namespace more than once. I can
change the global using to be local, but I don't think it makes sense to
either always put the using or never put it
On Mon, Mar 6, 2017 at 3:59 AM Tamas Berghammer via Phabricator <
reviews at reviews.llvm.org> wrote:

> tberghammer added a comment.
> Can you make the usage of "using namespace llvm::sys::fs;" a bit more
> consistent? Sometime you write fully qualified name, sometime you add it to
> the top of the file while sometime only to the function where it is used.
> ================
> Comment at: llvm/include/llvm/Support/FileSystem.h:482-486
>  /// @brief Does status represent a directory?
>  ///
>  /// @param status A file_status previously returned from status.
>  /// @returns status.type() == file_type::directory_file.
> +file_type get_file_type(const Twine &Path);
> ----------------
> Please fix the comment
> https://reviews.llvm.org/D30624
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170306/09d7663b/attachment.html>

More information about the lldb-commits mailing list