[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

That still seems wrong to me.  The UnixSignals class manages the data about signal state including how to respond to them, so it should be the class that comprehends that data.  The mental exercise of "if I had to do this in another place, would I have to duplicate an algorithm wholly specific to this class" is not over-engineering, it's how you decide where responsibility lies.  And in this case it's clear that if another process class wanted to do this job, it would have to duplicate this code, which means it doesn't belong in Process.


https://reviews.llvm.org/D30520