[Lldb-commits] [lldb] r296334 - Fix MinidumpParserTest on 32-bit arches

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 27 04:21:20 PST 2017


Author: labath
Date: Mon Feb 27 06:21:20 2017
New Revision: 296334

URL: http://llvm.org/viewvc/llvm-project?rev=296334&view=rev
Log:
Fix MinidumpParserTest on 32-bit arches

load_size should be 64-bit unconditionally to match the underlying API.
This makes sure the MAX value correctly signals to auto-detect the file
size when mmap()ing.

Modified:
    lldb/trunk/unittests/Process/minidump/MinidumpParserTest.cpp

Modified: lldb/trunk/unittests/Process/minidump/MinidumpParserTest.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Process/minidump/MinidumpParserTest.cpp?rev=296334&r1=296333&r2=296334&view=diff
==============================================================================
--- lldb/trunk/unittests/Process/minidump/MinidumpParserTest.cpp (original)
+++ lldb/trunk/unittests/Process/minidump/MinidumpParserTest.cpp Mon Feb 27 06:21:20 2017
@@ -48,7 +48,8 @@ public:
     llvm::sys::path::append(inputs_folder, "Inputs");
   }
 
-  void SetUpData(const char *minidump_filename, size_t load_size = SIZE_MAX) {
+  void SetUpData(const char *minidump_filename,
+                 uint64_t load_size = UINT64_MAX) {
     llvm::SmallString<128> filename = inputs_folder;
     llvm::sys::path::append(filename, minidump_filename);
 
@@ -452,4 +453,4 @@ TEST_F(MinidumpParserTest, ConvertMinidu
                 REG_VAL32(buf->GetBytes() + reg_info[reg_index].byte_offset));
     }
   }
-}
\ No newline at end of file
+}




More information about the lldb-commits mailing list