[Lldb-commits] [lldb] r296243 - Three LoadLibCxxFormatters formatters were given a regex string to

Jason Molenda via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 24 21:43:52 PST 2017


Author: jmolenda
Date: Fri Feb 24 23:43:51 2017
New Revision: 296243

URL: http://llvm.org/viewvc/llvm-project?rev=296243&view=rev
Log:
Three LoadLibCxxFormatters formatters were given a regex string to
match but the 'is_regex' argument was not passed as true.  Not sure
this is causing a bug, but noticed it while working on another bug.
These formatters gained a regex in r274489 for NDK but didn't pick
up the is_regex flag at the time.
<rdar://problem/30646077> 


Modified:
    lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp

Modified: lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp?rev=296243&r1=296242&r2=296243&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp (original)
+++ lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp Fri Feb 24 23:43:51 2017
@@ -624,14 +624,14 @@ static void LoadLibCxxFormatters(lldb::T
       lldb_private::formatters::LibcxxVectorBoolSyntheticFrontEndCreator,
       "libc++ std::vector<bool> synthetic children",
       ConstString("std::__(ndk)?1::vector<std::__(ndk)?1::allocator<bool> >"),
-      stl_synth_flags);
+      stl_synth_flags, true);
   AddCXXSynthetic(
       cpp_category_sp,
       lldb_private::formatters::LibcxxVectorBoolSyntheticFrontEndCreator,
       "libc++ std::vector<bool> synthetic children",
       ConstString(
           "std::__(ndk)?1::vector<bool, std::__(ndk)?1::allocator<bool> >"),
-      stl_synth_flags);
+      stl_synth_flags, true);
   AddCXXSynthetic(
       cpp_category_sp,
       lldb_private::formatters::LibcxxStdMapSyntheticFrontEndCreator,
@@ -765,7 +765,7 @@ static void LoadLibCxxFormatters(lldb::T
       "libc++ std::vector<bool> summary provider",
       ConstString(
           "std::__(ndk)?1::vector<bool, std::__(ndk)?1::allocator<bool> >"),
-      stl_summary_flags);
+      stl_summary_flags, true);
   AddCXXSynthetic(
       cpp_category_sp,
       lldb_private::formatters::LibCxxMapIteratorSyntheticFrontEndCreator,




More information about the lldb-commits mailing list