[Lldb-commits] [PATCH] D30249: Clear expression when breakpoint location becomes unresolved

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 22 12:39:50 PST 2017


labath added a comment.

> Note that the breakpoint location's site gets cleared when you disable the breakpoint or its location, as well as when you delete it.  So if you have a workflow that does: "hit a breakpoint, disable it, hit another, reenable the first, hit the second" you'll end up re-evaluating the condition expression unnecessarily.  This isn't a terribly common workflow, and compiling the expression is not hugely expensive.  But in this instance, it was probably better to break the link at the SBBreakpoint level, and not here.

Sorry, I thought I understood Greg wanted me to do this. I can certainly do the SBBreakpoint thing instead.


https://reviews.llvm.org/D30249





More information about the lldb-commits mailing list