[Lldb-commits] [lldb] r294219 - Remove the verbose category in the dwarf channel

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 6 11:19:30 PST 2017


Author: labath
Date: Mon Feb  6 13:19:30 2017
New Revision: 294219

URL: http://llvm.org/viewvc/llvm-project?rev=294219&view=rev
Log:
Remove the verbose category in the dwarf channel

Modified:
    lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
    lldb/trunk/source/Plugins/SymbolFile/DWARF/LogChannelDWARF.cpp
    lldb/trunk/source/Plugins/SymbolFile/DWARF/LogChannelDWARF.h

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp?rev=294219&r1=294218&r2=294219&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp Mon Feb  6 13:19:30 2017
@@ -256,16 +256,15 @@ size_t DWARFCompileUnit::ExtractDIEsIfNe
                                                          m_die_array.end());
     exact_size_die_array.swap(m_die_array);
   }
-  Log *verbose_log(
-      LogChannelDWARF::GetLogIfAll(DWARF_LOG_DEBUG_INFO | DWARF_LOG_VERBOSE));
-  if (verbose_log) {
+  Log *log(LogChannelDWARF::GetLogIfAll(DWARF_LOG_DEBUG_INFO));
+  if (log && log->GetVerbose()) {
     StreamString strm;
     Dump(&strm);
     if (m_die_array.empty())
       strm.Printf("error: no DIE for compile unit");
     else
       m_die_array[0].Dump(m_dwarf2Data, this, strm, UINT32_MAX);
-    verbose_log->PutString(strm.GetString());
+    log->PutString(strm.GetString());
   }
 
   if (!m_dwo_symbol_file)

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/LogChannelDWARF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/LogChannelDWARF.cpp?rev=294219&r1=294218&r2=294219&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/LogChannelDWARF.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/LogChannelDWARF.cpp Mon Feb  6 13:19:30 2017
@@ -78,8 +78,6 @@ void LogChannelDWARF::Disable(const char
       flag_bits &= ~DWARF_LOG_DEBUG_MAP;
     else if (::strcasecmp(arg, "default") == 0)
       flag_bits &= ~DWARF_LOG_DEFAULT;
-    else if (::strcasecmp(arg, "verbose") == 0)
-      flag_bits &= ~DWARF_LOG_VERBOSE;
     else if (::strncasecmp(arg, "comp", 4) == 0)
       flag_bits &= ~DWARF_LOG_TYPE_COMPLETION;
     else {
@@ -133,8 +131,6 @@ bool LogChannelDWARF::Enable(
       flag_bits |= DWARF_LOG_DEBUG_MAP;
     else if (::strcasecmp(arg, "default") == 0)
       flag_bits |= DWARF_LOG_DEFAULT;
-    else if (::strcasecmp(arg, "verbose") == 0)
-      flag_bits |= DWARF_LOG_VERBOSE;
     else if (::strncasecmp(arg, "comp", 4) == 0)
       flag_bits |= DWARF_LOG_TYPE_COMPLETION;
     else {

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/LogChannelDWARF.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/LogChannelDWARF.h?rev=294219&r1=294218&r2=294219&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/LogChannelDWARF.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/LogChannelDWARF.h Mon Feb  6 13:19:30 2017
@@ -16,7 +16,6 @@
 // Project includes
 #include "lldb/Core/Log.h"
 
-#define DWARF_LOG_VERBOSE (1u << 0)
 #define DWARF_LOG_DEBUG_INFO (1u << 1)
 #define DWARF_LOG_DEBUG_LINE (1u << 2)
 #define DWARF_LOG_DEBUG_PUBNAMES (1u << 3)




More information about the lldb-commits mailing list