[Lldb-commits] [PATCH] D29496: Push down more common code into PlatformPOSIX

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 3 09:04:35 PST 2017


labath created this revision.

- GetFileWithUUID: All platforms except PlatformDarwin had this.

However, I see no reason why this code would not apply there as well.

- GetProcessInfo, FindProcesses: The implementation was the same in all classes.

- GetFullNameForDylib: This code should apply to all non-darwin

platforms. I've kept the PlatformDarwin override as the situation is
different there.


https://reviews.llvm.org/D29496

Files:
  source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp
  source/Plugins/Platform/FreeBSD/PlatformFreeBSD.h
  source/Plugins/Platform/Kalimba/PlatformKalimba.cpp
  source/Plugins/Platform/Kalimba/PlatformKalimba.h
  source/Plugins/Platform/Linux/PlatformLinux.cpp
  source/Plugins/Platform/Linux/PlatformLinux.h
  source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
  source/Plugins/Platform/MacOSX/PlatformDarwin.h
  source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
  source/Plugins/Platform/NetBSD/PlatformNetBSD.h
  source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
  source/Plugins/Platform/POSIX/PlatformPOSIX.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29496.86975.patch
Type: text/x-patch
Size: 18134 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170203/15ff1bfa/attachment-0001.bin>


More information about the lldb-commits mailing list