[Lldb-commits] [PATCH] D29405: Install six.py copy into subdirectory lldb

[Kamil Rytarowski via Phabricator via lldb-commits]

krytarowski added a comment.

In https://reviews.llvm.org/D29405#663566, @labath wrote:

> It does not seem to work for me. I get this when I run ninja check-lldb in the build directory:
>
>   Traceback (most recent call last):
>     File "/usr/local/google/home/labath/ll/llvm/tools/lldb/test/dotest.py", line 6, in <module>
>       import lldbsuite.test
>     File "/usr/local/google/home/labath/ll/lldb/packages/Python/lldbsuite/test/__init__.py", line 5, in <module>
>       from . import dotest
>     File "/usr/local/google/home/labath/ll/lldb/packages/Python/lldbsuite/test/dotest.py", line 36, in <module>
>       from lldb import six
>   ImportError: No module named lldb
>
>
> Any idea what could be the cause?


I've installed lldb before running tests, I'm not sure if it has the impact on it.

> I have no issue with this approach in general (assuming it can be made to work), but I want to throw an alternative solution out there:
> 
> - Add a LLDB_USE_SYSTEM_SIX cmake option. If this option is set, LLDB will not install or use the built-in copy of six.py, but will rely on the system one instead.
> 
>   Thoughts?

It's less invasive, I will go for it.


Repository:
  rL LLVM

https://reviews.llvm.org/D29405