[Lldb-commits] [PATCH] D29266: Synchronize PlatformNetBSD with Linux

[Kamil Rytarowski via Phabricator via lldb-commits]

krytarowski added a comment.

In https://reviews.llvm.org/D29266#661839, @labath wrote:

> After looking at this closer, I don't think we will even need a separate class to achieve deduplication. The code is so heavily duplicated (see comments on the first three non-boilerplate functions, I did not look at the rest yet, but I expect the situation to be the same) already that we can just push the definitions down the existing class hierarchy and achieve massive savings that way. After we're done with that, I think we'll find that the PlatformLinux class will be so small that your current s/linux/netbsd/ approach will no longer be a problem.
>
> If @clayborg agrees with this approach, I can help you prepare the ground for that.


I'm looking forward to this approach. In the past NetBSD code was almost exact copy of the FreeBSD one. Once we will deduplicate the code, FreeBSD will catch up.


Repository:
  rL LLVM

https://reviews.llvm.org/D29266