[Lldb-commits] [PATCH] D29333: [CMake] Add accurate dependency specifications

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.

In https://reviews.llvm.org/D29333#661960, @beanz wrote:

> Thankfully CMake will not complain about circular dependencies in static archive targets. If it did, we'd really be in trouble because the LLDB dependencies graph has *lots* of circular dependencies. Actually, I think CMake even handles them properly on Linux, which should eliminate our need to add `--start-group` and `--end-group` to the linker command lines.


I was thinking about that as well. I am not sure if it will work if we actually need multiple iterations of the loop to get all the dependencies converging, but it may be worth trying out.

I am hoping we will be able to reduce the loops in the future. My plan is that after finishing with the Log class,  to move it to a new module, with clean and well defined dependencies (I need to remove all ConstStrings and LLDB Streams from it first), After that I want start moving other low level functionalities there as well. That got a bit delayed now, but I should be back to that in a week or two.


https://reviews.llvm.org/D29333