[Lldb-commits] [PATCH] D29095: Open ELF core dumps with more than 64K sections
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Jan 27 07:25:20 PST 2017
labath added a subscriber: lldb-commits.
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I've added a quick test to demonstrate what I had in mind.
> Unfortunately, unlike release_39 branch, I cannot open my core dump, but the problem seems unrelated. So I think I want to push it through and continue investigation what is not working this time.
That's kinda the reason I wanted to add tests. :)
This test would not have actually caught your new problem, but it could add at least some protection for the future, as I doubt many people will run into real files with this many sections.
I think this should be ok to put in if there are no objections from anyone else.
Comment at: source/Plugins/ObjectFile/ELF/ELFHeader.h:71
elf_half e_phentsize; ///< Size of a program header table entry.
- elf_half e_phnum; ///< Number of program header entries.
+ elf_half e_phnum_hdr; ///< Number of program header entries.
elf_half e_shentsize; ///< Size of a section header table entry.
> labath wrote:
> > I am wondering whether these is any use in keeping these old values. It sounds like it's a recipe for someone getting confused and using the wrong ones. What do you think about just deleting these?
> I will leave it to you - just tell me what you prefer. I see both pros and cons of my current code.
Ok, let's leave it this way then.
More information about the lldb-commits