[Lldb-commits] [PATCH] D29215: [LLDB][MIPS] Fix TestMiniDumpNew

[Pavel Labath via Phabricator via lldb-commits]

labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.

This seems like it's fixing the problem in the wrong place. Also, the assumption that the platform == host_platform is not correct (what about when the test is run on windows?)

I think we should either fix SBPlatform::GetTriple to return a correct triple (lldb already knows the triple since it has the core file. Whether that triple should be returned by the platform is a somewhat different question though) or make the test suite not depend on that.

I am confused as to why would this behavior occur only on mips hosts. I've seen the platform being set to remote-linux when the test is run from windows, and it works fine there. What is the actual error message you are getting?


Repository:
  rL LLVM

https://reviews.llvm.org/D29215