[Lldb-commits] [PATCH] D28808: Fix a bug where lldb does not respect the packet size.

Hafiz Abid Qadeer via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 18 10:26:03 PST 2017


abidh marked 2 inline comments as done.
abidh added inline comments.


================
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4006-4007
+        if (log)
+          log->Warning("Packet size is too small."
+                       "LLDB may face problems while writing memory");
+      }
----------------
clayborg wrote:
> Missing space between "small." and "LLDB". We should also warn once, not every time.
This function has a check at the top so the packet size is checked only once.


https://reviews.llvm.org/D28808





More information about the lldb-commits mailing list