[Lldb-commits] [PATCH] D28858: Replace getcwd with the llvm equivalent

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 18 06:10:58 PST 2017


labath created this revision.

getcwd() is not available (well.. um.. deprecated?) on windows, and the way
PosixApi.h is providing it causes strange compile errors when it's included in
the wrong order. The best way to avoid that is to just not use chdir.

This replaces all uses of getcwd in generic code. There are still a couple of
more uses, but these are in platform-specific code.

chdir() is causing a similar problem, but for that there is no llvm equivalent
for that (yet).


https://reviews.llvm.org/D28858

Files:
  include/lldb/Host/windows/PosixApi.h
  source/Host/windows/Windows.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
  source/Target/Platform.cpp
  source/Target/ProcessLaunchInfo.cpp
  source/Target/TargetList.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28858.84828.patch
Type: text/x-patch
Size: 5613 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170118/429d91c4/attachment.bin>


More information about the lldb-commits mailing list