[Lldb-commits] [lldb] r291204 - Revert part of cleanup to fix a build break

David Blaikie via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 5 17:42:56 PST 2017


Author: dblaikie
Date: Thu Jan  5 19:42:56 2017
New Revision: 291204

URL: http://llvm.org/viewvc/llvm-project?rev=291204&view=rev
Log:
Revert part of cleanup to fix a build break

Wasn't sure I could include ErrorHandling.h here, and evidently I wasn't
building this part (must've made the change using sed after getting
tired of fixing each compilation error individually).

Modified:
    lldb/trunk/tools/debugserver/source/DNBDataRef.cpp

Modified: lldb/trunk/tools/debugserver/source/DNBDataRef.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/DNBDataRef.cpp?rev=291204&r1=291203&r2=291204&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/DNBDataRef.cpp (original)
+++ lldb/trunk/tools/debugserver/source/DNBDataRef.cpp Thu Jan  5 19:42:56 2017
@@ -115,13 +115,18 @@ uint32_t DNBDataRef::GetMax32(offset_t *
   switch (byte_size) {
   case 1:
     return Get8(offset_ptr);
+    break;
   case 2:
     return Get16(offset_ptr);
+    break;
   case 4:
     return Get32(offset_ptr);
+    break;
   default:
-    llvm_unreachable("GetMax32 unhandled case!");
+    assert(!"GetMax32 unhandled case!");
+    break;
   }
+  return 0;
 }
 
 //----------------------------------------------------------------------
@@ -134,15 +139,21 @@ uint64_t DNBDataRef::GetMax64(offset_t *
   switch (size) {
   case 1:
     return Get8(offset_ptr);
+    break;
   case 2:
     return Get16(offset_ptr);
+    break;
   case 4:
     return Get32(offset_ptr);
+    break;
   case 8:
     return Get64(offset_ptr);
+    break;
   default:
-    llvm_unreachable("GetMax64 unhandled case!");
+    assert(!"GetMax64 unhandled case!");
+    break;
   }
+  return 0;
 }
 
 //----------------------------------------------------------------------




More information about the lldb-commits mailing list