[Lldb-commits] [PATCH] D27707: Remove code needed for supporting old VS versions.

[Hafiz Abid Qadeer via Phabricator via lldb-commits]

abidh created this revision.
abidh added a reviewer: zturner.
abidh added a subscriber: lldb-commits.

This code was probably needed to support VS2013 and is not needed now. I have built it with VS and mingw. Ok to remove it?


https://reviews.llvm.org/D27707

Files:
  include/lldb/Host/windows/PosixApi.h


Index: include/lldb/Host/windows/PosixApi.h
===================================================================
--- include/lldb/Host/windows/PosixApi.h
+++ include/lldb/Host/windows/PosixApi.h
@@ -75,15 +75,6 @@
 
 #endif // _MSC_VER
 
-// MSVC 2015 and higher have timespec.  Otherwise we need to define it
-// ourselves.
-#if !defined(_MSC_VER) || _MSC_VER < 1900
-struct timespec {
-  time_t tv_sec;
-  long tv_nsec;
-};
-#endif
-
 // Various useful posix functions that are not present in Windows.  We provide
 // custom implementations.
 int vasprintf(char **ret, const char *fmt, va_list ap);
@@ -113,20 +104,4 @@
 inline pid_t fork(void) { LLVM_BUILTIN_UNREACHABLE; }
 inline pid_t setsid(void) { LLVM_BUILTIN_UNREACHABLE; }
 
-// vsnprintf and snprintf are provided in MSVC 2015 and higher.
-#if _MSC_VER < 1900
-namespace lldb_private {
-int vsnprintf(char *buffer, size_t count, const char *format, va_list argptr);
-}
-
-// inline to avoid linkage conflicts
-int inline snprintf(char *buffer, size_t count, const char *format, ...) {
-  va_list argptr;
-  va_start(argptr, format);
-  int r = lldb_private::vsnprintf(buffer, count, format, argptr);
-  va_end(argptr);
-  return r;
-}
-#endif
-
 #endif


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27707.81203.patch
Type: text/x-patch
Size: 1214 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161213/07982d70/attachment-0001.bin>