[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Dec 1 02:48:36 PST 2016
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm, after you consider my comment below.
Comment at: packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py:30
+ # Indicating SR.FR bit status
+ fr_flag = 1
The reason I suggested a different signature for the function (`getExpectedBitsize(reg_info, reg_infos)`) was that then you would not need to maintain any global state. The function could compute the presence of the flag as necessary (maybe even via some helper function). Maybe we'd need to do some of the work multiple times, but it's not like this is performance critical code anyway.
If you don't want to do that, then at least indicate that this flag is mips-specific (`_mips_fr_flag`, leading underscore is python convention of "private").
More information about the lldb-commits