[Lldb-commits] [PATCH] D27291: Handle UTF-16 and UTF-32 constant CFStrings

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 30 18:05:22 PST 2016

jingham added a comment.

Other than the request for a more logging, this seems fine.

Comment at: source/Plugins/ExpressionParser/Clang/IRForTarget.cpp:514-515
+ default:
+   encoding_flags = 0x0600; /* fall back to 0x0600, kCFStringEncodingASCII */
+ }
+ Constant *encoding_arg = ConstantInt::get(i32_ty, encoding_flags, false);
The default case here expresses "I don't know what this string is so I'm just going to try ASCII".  That's fine, but we should log the unknown kind so that when this happens in the wild and we can't get a repro case, we'll be able to figure out something from the log.



More information about the lldb-commits mailing list