[Lldb-commits] [PATCH] D27223: Expression evaluation for overloaded C functions (redux)

[Alexander Shaposhnikov via Phabricator via lldb-commits]

alexshap added inline comments.


================
Comment at: include/lldb/Core/FastDemangle.h:22
+char *
+FastDemangle(const char *mangled_name, size_t mangled_name_length,
+             std::function<void(const char *s)> primitive_type_hook = nullptr);
----------------
some thoughts: 
(also i assume i might be mistaken / missing smth) 
in ./source/Core/Mangled.cpp at least 3 demanglers are used:
FastDemangle, itaniumDemangle, abi::__cxa_demangle .
Adding primitive_type_hook to FastDemangle makes  the interface 
more complicated & inconsistent (although yes, it's not particularly consistent right now). 


================
Comment at: packages/Python/lldbsuite/test/expression_command/call-overloaded-c-fuction/main.c:17
+    return 0; // break here
+}
----------------
does this patch work when the functions come from a shared library ? 
(i mean if we have libFoo.so which contains the implementations of get_arg_type(float), get_arg_type(int), and then in lldb we want to call "p get_arg_type(0.12f)")


https://reviews.llvm.org/D27223