[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

[Kuba (Brecka) Mracek via Phabricator via lldb-commits]

kubabrecka added a comment.

In https://reviews.llvm.org/D27017#604265, @clayborg wrote:

> Looks fine. One question though: do we always have a shared library that contains the ASAN runtime? If so, then we can actually put the array of short to long description into the ASAN dylib and then we read this array as a global variable. This would allow you to add as many descriptions as you want directly in your ASAN code and have LLDB detect all of the new strings. Or, if there is a function you can call with the short description that returns the long description, then we can still have the ASAN code contain all of the strings.


We do have the dylib with the runtime any time this code is run.  However, I don't think these should live in the ASan runtime, because they should be considered as more high-level user-visible strings.  The ASan runtime itself produces detailed technical reports that don't use the wording used here.  For example, the console report will just say "Invalid pointer pair" assuming the user knows what that means.  When using LLDB (and/or Xcode) we should provide less technical descriptions.

Anyway, I think this asks for a longer discussion.  Are you okay with leaving these strings here for now?


https://reviews.llvm.org/D27017