[Lldb-commits] [lldb] r288027 - skip android in @skipIfHostIncompatibleWithRemote

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 28 04:15:20 PST 2016

Author: labath
Date: Mon Nov 28 06:15:19 2016
New Revision: 288027

URL: http://llvm.org/viewvc/llvm-project?rev=288027&view=rev
skip android in @skipIfHostIncompatibleWithRemote

The current implementation of the decorator does not skip if the android target
arch is the same as host arch (as in both cases the platform comes out as linux).
Nonetheless android x86_64 binaries are not compatible with linux ones.

Technically this should be "skip if target is android and host is *not* android",
but currently nobody runs lldb test suite on an android host, so we don't even
have a way of specifying that the host is android.


Modified: lldb/trunk/packages/Python/lldbsuite/test/decorators.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/decorators.py?rev=288027&r1=288026&r2=288027&view=diff
--- lldb/trunk/packages/Python/lldbsuite/test/decorators.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/decorators.py Mon Nov 28 06:15:19 2016
@@ -617,9 +617,11 @@ def skipIfHostIncompatibleWithRemote(fun
                 'i386') and host_arch != target_arch:
             return "skipping because target %s is not compatible with host architecture %s" % (
                 target_arch, host_arch)
-        elif target_platform != host_platform:
+        if target_platform != host_platform:
             return "skipping because target is %s but host is %s" % (
                 target_platform, host_platform)
+        if lldbplatformutil.match_android_device(target_arch):
+            return "skipping because target is android"
         return None
     return skipTestIfFn(is_host_incompatible_with_remote)(func)

More information about the lldb-commits mailing list