[Lldb-commits] [PATCH] D26971: Introduce chrono to more gdb-remote functions

[Pavel Labath via lldb-commits]

labath added a comment.

In https://reviews.llvm.org/D26971#602738, @clayborg wrote:

> It would be nice if we can find a way to be able to use any time units we want when specifying the timeout. I would rather not have everyone have to convert their times to microseconds. Maybe we just add some overloads to the public facing functions and have just one internal function that uses llvm::Optional.


I am not sure what would the public-facing functions be in this case. All of the code here is internal to the plugin, but I was definitely annoyed when I had to convert everything to microsecs. I am afraid we will have to make overloads of many functions to make the usages here clean.

I am going to try to see how hairy the new optional class ends up looking. I like that more as it concentrates the uglyness into one place.


https://reviews.llvm.org/D26971