[Lldb-commits] [lldb] r287597 - Add the new Args / entry-access API.

[Omair Javaid via lldb-commits]

Proposed change didnt fix the build errors so I have reverted changes
from rev 287597

On 22 November 2016 at 14:18, Zachary Turner <zturner at google.com> wrote:
> Ack, I caught this and fixed it, but it looks like I didn't dcommit the fix.
> I have no access until morning but if someone else does, you can either
> revert or change return type to vector<ArgEntry>::const_iterator
>
> On Tue, Nov 22, 2016 at 12:45 AM Omair Javaid <omair.javaid at linaro.org>
> wrote:
>>
>> Linux buildbot also failing with similar errors.
>>
>> On 22 November 2016 at 09:26, Ed Maste via lldb-commits
>> <lldb-commits at lists.llvm.org> wrote:
>> > On 21 November 2016 at 18:18, Zachary Turner via lldb-commits
>> > <lldb-commits at lists.llvm.org> wrote:
>> >> Author: zturner
>> >> Date: Mon Nov 21 17:18:07 2016
>> >> New Revision: 287597
>> >>
>> >> URL: http://llvm.org/viewvc/llvm-project?rev=287597&view=rev
>> >> Log:
>> >> Add the new Args / entry-access API.
>> >
>> > FreeBSD buildbot is now failing with:
>> > http://lab.llvm.org:8011/builders/lldb-amd64-ninja-freebsd11/builds/1462
>> >
>> > [2160/2918] Building CXX object
>> > tools/lldb/source/Symbol/CMakeFiles/lldbSymbol.dir/Function.cpp.o
>> > FAILED:
>> > tools/lldb/source/Symbol/CMakeFiles/lldbSymbol.dir/Function.cpp.o
>> > /usr/bin/CC   -DGTEST_HAS_RTTI=0 -DHAVE_ROUND
>> > -DLLDB_USE_BUILTIN_DEMANGLER -D__STDC_CONSTANT_MACROS
>> > -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
>> > -Itools/lldb/source/Symbol
>> > -I/usr/home/buildbot/scratch/scratch/llvm/tools/lldb/source/Symbol
>> > -I/usr/home/buildbot/scratch/scratch/llvm/tools/lldb/include
>> > -Itools/lldb/include -Iinclude
>> > -I/usr/home/buildbot/scratch/scratch/llvm/include -I/usr/local/include
>> > -I/usr/local/include/python2.7
>> > -I/usr/home/buildbot/scratch/scratch/llvm/tools/clang/include
>> > -Itools/lldb/../clang/include
>> > -I/usr/home/buildbot/scratch/scratch/llvm/tools/lldb/source/.
>> >
>> > -I/usr/home/buildbot/scratch/scratch/llvm/tools/lldb/source/Plugins/Process/FreeBSD
>> >
>> > -I/usr/home/buildbot/scratch/scratch/llvm/tools/lldb/source/Plugins/Process/POSIX
>> > -fPIC -fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter
>> > -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic
>> > -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor
>> > -Wdelete-non-virtual-dtor -Werror=date-time -std=c++11
>> > -fcolor-diagnostics -ffunction-sections -fdata-sections
>> > -Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-strict-aliasing
>> > -Wno-deprecated-register -Wno-vla-extension -fPIC -fPIC -O3 -DNDEBUG
>> >  -fno-exceptions -fno-rtti -MMD -MT
>> > tools/lldb/source/Symbol/CMakeFiles/lldbSymbol.dir/Function.cpp.o -MF
>> > tools/lldb/source/Symbol/CMakeFiles/lldbSymbol.dir/Function.cpp.o.d -o
>> > tools/lldb/source/Symbol/CMakeFiles/lldbSymbol.dir/Function.cpp.o -c
>> >
>> > /usr/home/buildbot/scratch/scratch/llvm/tools/lldb/source/Symbol/Function.cpp
>> > In file included from
>> >
>> > /usr/home/buildbot/scratch/scratch/llvm/tools/lldb/source/Symbol/Function.cpp:20:
>> > In file included from
>> >
>> > /usr/home/buildbot/scratch/scratch/llvm/tools/lldb/include/lldb/Target/Language.h:25:
>> > In file included from
>> >
>> > /usr/home/buildbot/scratch/scratch/llvm/tools/lldb/include/lldb/DataFormatters/FormatClasses.h:22:
>> > In file included from
>> >
>> > /usr/home/buildbot/scratch/scratch/llvm/tools/lldb/include/lldb/DataFormatters/TypeFormat.h:27:
>> > In file included from
>> >
>> > /usr/home/buildbot/scratch/scratch/llvm/tools/lldb/include/lldb/Core/ValueObject.h:34:
>> > In file included from
>> >
>> > /usr/home/buildbot/scratch/scratch/llvm/tools/lldb/include/lldb/Target/Process.h:43:
>> > In file included from
>> >
>> > /usr/home/buildbot/scratch/scratch/llvm/tools/lldb/include/lldb/Interpreter/Options.h:20:
>> >
>> > /usr/home/buildbot/scratch/scratch/llvm/tools/lldb/include/lldb/Interpreter/Args.h:155:3:
>> > error: 'auto' return without trailing return type; deduced return
>> > types are a C++14 extension
>> >   auto begin() const { return m_entries.begin(); }
>> >   ^
>> >
>> > /usr/home/buildbot/scratch/scratch/llvm/tools/lldb/include/lldb/Interpreter/Args.h:156:3:
>> > error: 'auto' return without trailing return type; deduced return
>> > types are a C++14 extension
>> >   auto end() const { return m_entries.end(); }
>> >   ^
>> >
>> > /usr/home/buildbot/scratch/scratch/llvm/tools/lldb/include/lldb/Interpreter/Args.h:155:31:
>> > error: no viable conversion from 'const_iterator' (aka
>> > '__wrap_iter<const_pointer>') to 'int'
>> >   auto begin() const { return m_entries.begin(); }
>> >                               ^~~~~~~~~~~~~~~~~
>> >
>> > /usr/home/buildbot/scratch/scratch/llvm/tools/lldb/include/lldb/Interpreter/Args.h:156:29:
>> > error: no viable conversion from 'const_iterator' (aka
>> > '__wrap_iter<const_pointer>') to 'int'
>> >   auto end() const { return m_entries.end(); }
>> >                             ^~~~~~~~~~~~~~~
>> > 4 errors generated.
>> > _______________________________________________
>> > lldb-commits mailing list
>> > lldb-commits at lists.llvm.org
>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits