[Lldb-commits] [PATCH] D26676: Patch for lldb bug 26322 “core load hangs”

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 21 05:33:22 PST 2016


On 18 November 2016 at 19:54, Jim Ingham <jingham at apple.com> wrote:
> If we are going to do that, I wonder if we should start having tests share their inputs.  We don’t do that for source files because the cost of duplication is so small, and then you don’t have the hassle of adding something to a source fie for test A messes up test B.  But for binaries like core files, it might be worth that hassle.  Especially as we need to pick up core files for a bunch of different architectures.

I certainly agree that we should avoid copying the core files around,
but I am not sure we actually need to do something special to make
that possible. If we just place all the tests that access the same
core file in the same folder then they will end up sharing it
naturally (The only reason we tend to have tests in separate folders
right now is because it's hard to teach make to build the proper
executable with many source files together). If we ever need to reuse
the same file for tests that are so logically separate that it makes
sense for them to live in different places, we can come up with a some
sort of a central core file repository, but I think that can wait
until we encounter such situation.

pl


More information about the lldb-commits mailing list