[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

[Luke Drummond via lldb-commits]

ldrumm added inline comments.


================
Comment at: CMakeLists.txt:46
+        COMMAND
+           ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/scripts/finishSwigWrapperClasses.py
+               --srcRoot=${LLDB_SOURCE_DIR}
----------------
bryant wrote:
> You can reduce diff noise by leaving formatting changes for a separate patch.
Seeing as I'm touching all these lines anyway, formatting seems appropriate. I tend to get pushback for formatting only commits, so I'd rather keep this as it is.


================
Comment at: CMakeLists.txt:53
+               --lldbLibDir=lib${LLVM_LIBDIR_SUFFIX}
+           ${FINISH_EXTRA_ARGS}
+        VERBATIM
----------------
bryant wrote:
> The indentation here could match the above.
Good point. Will fix


https://reviews.llvm.org/D26757