[Lldb-commits] [PATCH] D26676: Patch for lldb bug 26322 “core load hangs”

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 16 02:23:14 PST 2016


labath added inline comments.


================
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:224
+      // If all else fails force the first thread to be SIGSTOP
+      m_thread_data.begin()->signo = SIGSTOP;
+    }
----------------
You should not use signal numbers from the host here -- the macro may not be present (windows), or it may not have the same value. You need to get the correct set of signals with Process::GetUnixSignals(), and then look up the signal by name.


https://reviews.llvm.org/D26676





More information about the lldb-commits mailing list