[Lldb-commits] [PATCH] D26393: Disable windows-only minidump plugin

Adrian McCarthy via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 8 09:55:01 PST 2016

amccarth added a comment.

In https://reviews.llvm.org/D26393#589421, @labath wrote:

> In https://reviews.llvm.org/D26393#589363, @amccarth wrote:
> > I started testing the new plugin on Windows yesterday, and it doesn't work (all the tests fail).  I'm planning to debug today, and, once I get it working, I'd be happy to switch it over.
> Interesting. It seemed to work fine for me. How did you test that?

I made changes very similar to this patch and ran check-lldb.  The tests for the new minidump plugin passed, but the original Windows ones all failed, apparently because it cannot find any threads in the dumps.  I'll have more time to look at it this afternoon.


More information about the lldb-commits mailing list