[Lldb-commits] [PATCH] D26249: [unittests] Split DWARF tests out of PDB, fix standalone build

[Michał Górny via lldb-commits]

mgorny retitled this revision from "[unittests] Avoid the dependency on private LLVM headers outside MSVC" to "[unittests] Split DWARF tests out of PDB, fix standalone build".
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 76766.
mgorny added a comment.
Herald added a subscriber: modocache.

Here's an updated patch. I've decided to go for the initial idea of splitting the tests, combined with LLVMConfig update.

https://reviews.llvm.org/D26255 updates LLVM to include LLVM_ENABLE_DIA_SDK in LLVMConfig.cmake (it already provides similar variables). The variable is also still used to set HAVE_DIA_SDK in config.h, so old versions of LLDB will continue to build fine in-tree.

This one splits the previous test into DWARF and actual PDB tests. The DWARF test is run unconditionally, while the other is run only when DIA SDK is available. As I said, I don't have Windows handy, so I wasn't able to test the latter part. However, unless I failed at syntax when modifying it, it should work (I only removed the include, the DWARF test and file, and removed the DIA SDK magic).


https://reviews.llvm.org/D26249

Files:
  unittests/SymbolFile/CMakeLists.txt
  unittests/SymbolFile/DWARF/CMakeLists.txt
  unittests/SymbolFile/DWARF/Inputs/test-dwarf.cpp
  unittests/SymbolFile/DWARF/Inputs/test-dwarf.exe
  unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp
  unittests/SymbolFile/PDB/CMakeLists.txt
  unittests/SymbolFile/PDB/Inputs/test-dwarf.cpp
  unittests/SymbolFile/PDB/Inputs/test-dwarf.exe
  unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26249.76766.patch
Type: text/x-patch
Size: 12043 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161102/db2a8237/attachment.bin>