[Lldb-commits] [PATCH] D26249: [unittests] Avoid the dependency on private LLVM headers outside MSVC

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 2 09:53:34 PDT 2016


zturner added a comment.

What if we added a function to `llvm/DebugInfo/PDB/PDB.h` called `isDiaSupported()`, and in the implementation it returns `true` if the definition is present and `false` otherwise.  Then instead of using the pre-processor to decide whether to run the test, we run all of them but just return `true` if `isDiaSupported()` returns `false`?


https://reviews.llvm.org/D26249





More information about the lldb-commits mailing list