[Lldb-commits] [PATCH] D26170: Find clang resource directory via *nix-style lookup

[Todd Fiala via lldb-commits]

tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.

Looks reasonable.



================
Comment at: source/Host/macosx/HostInfoMacOSX.mm:235-239
   size_t framework_pos = raw_path.find("LLDB.framework");
-  if (framework_pos != std::string::npos) {
-    framework_pos += strlen("LLDB.framework");
-    raw_path.resize(framework_pos);
-    raw_path.append("/Resources/Clang");
-  }
+  if (framework_pos == std::string::npos)
+    return HostInfoPosix::ComputeClangDirectory(file_spec);
+  
+  framework_pos += strlen("LLDB.framework");
----------------
We should have a const in place of the two uses of "LLDB.framework", but that can be a separate cleanup.


https://reviews.llvm.org/D26170