[Lldb-commits] [PATCH] D25830: Search for llvm-config in LLDB_PATH_TO_LLVM_BUILD first

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 20 09:22:21 PDT 2016


tfiala added inline comments.


================
Comment at: cmake/modules/LLDBStandalone.cmake:20
+  find_program(LLVM_CONFIG "llvm-config"
+    HINTS ${FIND_PATHS})
   if(LLVM_CONFIG)
----------------
One question here would be what happens if FIND_PATHS stays "".  Does find_program deal with an empty HINTS?  If not, the HINTS clause itself might need to be conditionalized.


Repository:
  rL LLVM

https://reviews.llvm.org/D25830





More information about the lldb-commits mailing list