[Lldb-commits] [PATCH] D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class
Vadim Macagon via lldb-commits
lldb-commits at lists.llvm.org
Fri Oct 14 02:04:29 PDT 2016
enlight marked an inline comment as done.
enlight added inline comments.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:116
- return m_pUnkwn;
+ return kUnresolvedValue;
> After couple of minutes I see the lack of logic there: the value is still composite but we return kUnresolvedValue instead of kUnresolvedCompositeValue.
> I think we have to rename kUnresolvedValue back to kUnknownValue.
Yep, good point, I've renamed it back.
More information about the lldb-commits