[Lldb-commits] [lldb] r283324 - xfailing minidump tests again ... :(

[Pavel Labath via lldb-commits]

Agreed (don't forget the xcode changes too). Also, the binaries you've
checked in trying to fix this are quite big (and now part of history
forever). I think we'll have to come up with a different way to test this.

BTW, the reason why tests are failing on the buildbot is most likely
because the paths in the precompiled debug info, don't match the buildbot
paths.

I should've seen this coming. Sorry about that.

pl

On 5 October 2016 at 08:38, Zachary Turner via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

> If all the tests are being xfailed you should probably just revert the
> original patch until the tests are fixed
>
> On Wed, Oct 5, 2016 at 8:09 AM Dimitar Vlahovski via lldb-commits <
> lldb-commits at lists.llvm.org> wrote:
>
>> Author: dvlahovski
>> Date: Wed Oct  5 10:00:29 2016
>> New Revision: 283324
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=283324&view=rev
>> Log:
>> xfailing minidump tests again ... :(
>>
>> Modified:
>>     lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/
>> minidump-new/TestMiniDumpNew.py
>>
>> Modified: lldb/trunk/packages/Python/lldbsuite/test/
>> functionalities/postmortem/minidump-new/TestMiniDumpNew.py
>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/
>> Python/lldbsuite/test/functionalities/postmortem/
>> minidump-new/TestMiniDumpNew.py?rev=283324&r1=283323&r2=283324&view=diff
>> ============================================================
>> ==================
>> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/
>> minidump-new/TestMiniDumpNew.py (original)
>> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/
>> minidump-new/TestMiniDumpNew.py Wed Oct  5 10:00:29 2016
>> @@ -18,6 +18,7 @@ class MiniDumpNewTestCase(TestBase):
>>
>>      NO_DEBUG_INFO_TESTCASE = True
>>
>> +    @expectedFailureAll
>>      def test_process_info_in_minidump(self):
>>          """Test that lldb can read the process information from the
>> Minidump."""
>>          # target create -c linux-x86_64.dmp
>> @@ -28,6 +29,7 @@ class MiniDumpNewTestCase(TestBase):
>>          self.assertEqual(self.process.GetNumThreads(), 1)
>>          self.assertEqual(self.process.GetProcessID(), 16001)
>>
>> +    @expectedFailureAll
>>      def test_thread_info_in_minidump(self):
>>          """Test that lldb can read the thread information from the
>> Minidump."""
>>          # target create -c linux-x86_64.dmp
>> @@ -42,6 +44,7 @@ class MiniDumpNewTestCase(TestBase):
>>          stop_description = thread.GetStopDescription(256)
>>          self.assertTrue("SIGSEGV" in stop_description)
>>
>> +    @expectedFailureAll
>>      def test_stack_info_in_minidump(self):
>>          """Test that we can see a trivial stack in a breakpad-generated
>> Minidump."""
>>          # target create linux-x86_64 -c linux-x86_64.dmp
>> @@ -62,6 +65,7 @@ class MiniDumpNewTestCase(TestBase):
>>          self.assertTrue(eip.IsValid())
>>          self.assertEqual(pc, eip.GetValueAsUnsigned())
>>
>> +    @expectedFailureAll
>>      def test_snapshot_minidump(self):
>>          """Test that if we load a snapshot minidump file (meaning the
>> process did not crash) there is no stop reason."""
>>          # target create -c linux-x86_64_not_crashed.dmp
>> @@ -74,6 +78,7 @@ class MiniDumpNewTestCase(TestBase):
>>          stop_description = thread.GetStopDescription(256)
>>          self.assertEqual(stop_description, None)
>>
>> +    @expectedFailureAll
>>      def test_deeper_stack_in_minidump(self):
>>          """Test that we can examine a more interesting stack in a
>> Minidump."""
>>          # Launch with the Minidump, and inspect the stack.
>> @@ -90,6 +95,7 @@ class MiniDumpNewTestCase(TestBase):
>>              function_name = frame.GetFunctionName()
>>              self.assertTrue(name in function_name)
>>
>> +    @expectedFailureAll
>>      def test_local_variables_in_minidump(self):
>>          """Test that we can examine local variables in a Minidump."""
>>          # Launch with the Minidump, and inspect a local variable.
>>
>>
>> _______________________________________________
>> lldb-commits mailing list
>> lldb-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161005/939ec5cd/attachment.html>