[Lldb-commits] [PATCH] D25158: Convert some Breakpoint to StringRef

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 4 14:38:43 PDT 2016


Ah, missed it there.  No it is fine to put it in the header.

Jim

> On Oct 4, 2016, at 2:37 PM, Zachary Turner <zturner at google.com> wrote:
> 
> zturner added inline comments.
> 
> 
>> jingham wrote in BreakpointIDList.cpp:329-330
>> Did you upload the latest version of your patch, I don't see a comment here...
> 
> I put the comment in the header.  I can put it here if you prefer.  Putting it on both places seems unnecessary though.  LMK which you prefer.  I'll fix up the header doc of the other function in the meantime.
> 
> https://reviews.llvm.org/D25158
> 
> 
> 



More information about the lldb-commits mailing list