[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

[Dimitar Vlahovski via lldb-commits]

dvlahovski marked an inline comment as done.
dvlahovski added inline comments.


> zturner wrote in MinidumpParser.cpp:81-82
> Change this line to  `return GetData().slice(iter->second.rva, iter->second.data_size);`

Nice! :)

> zturner wrote in MinidumpParser.h:35-36
> If the comment is long enough to wrap, maybe better to just put it on the line before.  Looks awkward this way.

This comment is for the ArrayrRef. Added a clarification

> zturner wrote in MinidumpTypes.cpp:188-190
> you can write `return llvm::makeArrayRef(reinterpret_cast<const MinidumpMemoryDescriptor*>(data.data()), *mem_ranges_count));` to avoid specifying the type name twice.  It's a little shorter (admittedly not much though).

I think it looks better with the makeArrayrRef :)

https://reviews.llvm.org/D25196