[Lldb-commits] [PATCH] D25099: Refactor Args a different way

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 3 14:39:58 PDT 2016


jingham added a comment.

You messed up the meaning of one comment (noted inline).  Otherwise this looks fine to me too.



> Args.cpp:97-98
> +  // Argument can be split into multiple discontiguous pieces, for example:
> +  //  "Hello " "World"
> +  // this would result in a single argument "Hello World" (without the quotes)
> +  // since the quotes would be removed and there is not space between the

The example needs to be "Hello ""World" or it doesn't make sense.  "Hello " "World" with a space in between would be two arguments.

https://reviews.llvm.org/D25099





More information about the lldb-commits mailing list