[Lldb-commits] [PATCH] D25201: Fix GetDisplayName when only a demangled name is available

Francis Ricci via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 3 11:14:08 PDT 2016


fjricci created this revision.
fjricci added reviewers: clayborg, granata.enrico.
fjricci added a subscriber: lldb-commits.

GetDisplayDemangledName will already return a ConstString() when
there is neither a mangled name or a demangled name, so we don't need to special
case here. This will fix GetDisplayName in cases where m_mangled contains
only a demangled name and not a mangled name.


https://reviews.llvm.org/D25201

Files:
  source/Symbol/Function.cpp
  source/Symbol/Symbol.cpp


Index: source/Symbol/Symbol.cpp
===================================================================
--- source/Symbol/Symbol.cpp
+++ source/Symbol/Symbol.cpp
@@ -117,8 +117,6 @@
 }
 
 ConstString Symbol::GetDisplayName() const {
-  if (!m_mangled)
-    return ConstString();
   return m_mangled.GetDisplayDemangledName(GetLanguage());
 }
 
Index: source/Symbol/Function.cpp
===================================================================
--- source/Symbol/Function.cpp
+++ source/Symbol/Function.cpp
@@ -347,8 +347,6 @@
 }
 
 ConstString Function::GetDisplayName() const {
-  if (!m_mangled)
-    return ConstString();
   return m_mangled.GetDisplayDemangledName(GetLanguage());
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25201.73307.patch
Type: text/x-patch
Size: 688 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161003/2b08ca02/attachment-0001.bin>


More information about the lldb-commits mailing list