[Lldb-commits] [lldb] r282445 - Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring

[Enrico Granata via lldb-commits]

> On Sep 26, 2016, at 3:03 PM, Zachary Turner <zturner at google.com> wrote:
> 
> Oh cool. Is it not hooked up to the public waterfall?

That's a really good question...
It's marked @skipUnlessDarwin, but that's about all that is remarkable about it; I know about the failure because someone internally at Apple filed a bug report about it, but didn't get any bot emails complaining (and apparently neither did you)

Weird.. With that said, if you care to try, it's expression_command/po_verbosity

> On Mon, Sep 26, 2016 at 3:02 PM Enrico Granata <egranata at apple.com <mailto:egranata at apple.com>> wrote:
>> On Sep 26, 2016, at 2:50 PM, Zachary Turner <zturner at google.com <mailto:zturner at google.com>> wrote:
>> 
>> Test would be nice, but otoh command line tests are discouraged. Maybe it will be easier to write this kind of test if we had a tool specifically for testing command line options similar to what I proposed with unwinding etc. oh well
> 
> There already is a test for this - that's how the breakage was caught to begin with :-)
> 
>> On Mon, Sep 26, 2016 at 2:45 PM Enrico Granata via lldb-commits <lldb-commits at lists.llvm.org <mailto:lldb-commits at lists.llvm.org>> wrote:
>> Author: enrico
>> Date: Mon Sep 26 16:36:17 2016
>> New Revision: 282445
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=282445&view=rev <http://llvm.org/viewvc/llvm-project?rev=282445&view=rev>
>> Log:
>> Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring
>> 
>> Fixes rdar://28480275 <>
>> 
>> 
>> Modified:
>>     lldb/trunk/source/Commands/CommandObjectExpression.cpp
>> 
>> Modified: lldb/trunk/source/Commands/CommandObjectExpression.cpp
>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectExpression.cpp?rev=282445&r1=282444&r2=282445&view=diff <http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectExpression.cpp?rev=282445&r1=282444&r2=282445&view=diff>
>> ==============================================================================
>> --- lldb/trunk/source/Commands/CommandObjectExpression.cpp (original)
>> +++ lldb/trunk/source/Commands/CommandObjectExpression.cpp Mon Sep 26 16:36:17 2016
>> @@ -142,7 +142,7 @@ Error CommandObjectExpression::CommandOp
>>    }
>> 
>>    case 'v':
>> -    if (!option_arg.empty()) {
>> +    if (option_arg.empty()) {
>>        m_verbosity = eLanguageRuntimeDescriptionDisplayVerbosityFull;
>>        break;
>>      }
>> 
>> 
>> _______________________________________________
>> lldb-commits mailing list
>> lldb-commits at lists.llvm.org <mailto:lldb-commits at lists.llvm.org>
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits>
> 
> 
> 
> Thanks,
> - Enrico
> 📩 egranata@.com ☎️ 27683
> 


Thanks,
- Enrico
📩 egranata@.com ☎️ 27683

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160926/066b0461/attachment.html>