[Lldb-commits] [lldb] r281507 - Use Intel CPU flags to determine target supported features.

[Zachary Turner via lldb-commits]

Can probably do the same for XStateType as well:

enum class XStateType { Invalid, FXSAVE, XSAVE };



On Wed, Sep 14, 2016 at 10:46 AM Zachary Turner <zturner at google.com> wrote:

> On Wed, Sep 14, 2016 at 10:36 AM Valentina Giusti via lldb-commits <
> lldb-commits at lists.llvm.org> wrote:
>
>
> ==============================================================================
> ---
> lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.h
> (original)
> +++
> lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.h
> Wed Sep 14 12:27:48 2016
> @@ -77,7 +77,8 @@ protected:
>
>  private:
>    // Private member types.
> -  enum FPRType { eFPRTypeNotValid = 0, eFPRTypeFXSAVE, eFPRTypeXSAVE };
> +  enum XStateType { eXStateTypeNotValid = 0, eXStateTypeFXSAVE,
> eXStateTypeXSAVE };
> +  enum RegSet { gpr, fpu, avx, mpx };
>
>
> This still isn't an enum class.  You need to write:
>
> enum class RegSet { gpr, fpu, avx, mpx };
>
> Can you make this change and submit it as a followup please?
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160914/d8f95b85/attachment.html>