[Lldb-commits] [PATCH] D24283: [lldb] Set the correct triple when creating an ArchSpec for windows

[Zachary Turner via lldb-commits]

zturner added a comment.

In https://reviews.llvm.org/D24283#541645, @wallace wrote:

> I've run the tests and saw that two tests have been fixed
> before:
>
>   Test Methods:       1829
>   Reruns:                0
>   Success:            1061
>   Expected Failure:    113
>   Failure:               0
>   Error:                 7
>   Exceptional Exit:      0
>   Unexpected Success:   11
>   Skip:                637
>   Timeout:               0
>   Expected Timeout:      0
>   
>
> After
>
>   Test Methods:       1829
>   Reruns:                0
>   Success:            1061
>   Expected Failure:    115
>   Failure:               0
>   Error:                 7
>   Exceptional Exit:      0
>   Unexpected Success:    9
>   Skip:                637
>   Timeout:               0
>   Expected Timeout:      0
>   
>
> So Expected Failures increased by two


Actually that means two tests have been broken :)  Before they were succeeding even though we thought they should fail, and now they are failing as we would expect them to do.  I'm not sure if this is good or bad.  :)  Is there any way you could run the test suite twice, once with your patch and once without, and see which two tests it is?  And maybe post the log files of the two tests now that they are failing?


https://reviews.llvm.org/D24283