[Lldb-commits] [PATCH] D24369: [support] copying JSON parser/writer from lldb

Mike Aizatsky via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 9 19:31:23 PDT 2016


Oh, that's great! Thanks for pointing this out. I'll just upload the
cleaned up version in case lldb/ folks would like it. I'll figure out how
to use our YAML library.

On Fri, Sep 9, 2016 at 6:48 PM Chandler Carruth <chandlerc at gmail.com> wrote:

> chandlerc added a comment.
>
> In https://reviews.llvm.org/D24369#538472, @zturner wrote:
>
> > In https://reviews.llvm.org/D24369#538422, @aizatsky wrote:
> >
> > > > I'm a bit surprised there's not already a json parser in LLVM.
> Maybe there's a reason for it.  I think this CL needs a few more reviewers
> on the LLVM side, so I'm adding a few people.
> > >
> >
>
>
> There is already a JSON parser in LLVM.
>
> > > I can't actually find json parser within clang-tidy. Only references
> that I see lead eventually to YAML parsing:
>
> >
>
> >
>
> > I was thinking of `lib/Tooling/JSONCompilationDatabase`, but looking at
> it, it seems to be pretty specialized and doesn't support arbitrary JSON.
>
>
> It uses the YAML parser because JSON is a strict subset of YAML:
> https://en.wikipedia.org/wiki/JSON#YAML
>
> Please don't add a JSON parser to LLVM. I would much rather teach LLDB to
> use the YAML parser and improve that parser if and where useful.
>
>
> https://reviews.llvm.org/D24369
>
>
>
> --
Mike
Sent from phone
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160910/ac9ec00e/attachment-0001.html>


More information about the lldb-commits mailing list