[Lldb-commits] [PATCH] D23977: Support of lldb on Kfreebsd

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 9 10:24:02 PDT 2016


tfiala added inline comments.

================
Comment at: cmake/LLDBDependencies.cmake:168
@@ -167,3 +167,3 @@
 # On FreeBSD/NetBSD backtrace() is provided by libexecinfo, not libc.
-if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+if ((CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "NetBSD") AND NOT CMAKE_SYSTEM_NAME STREQUAL "kFreeBSD")
   list(APPEND LLDB_SYSTEM_LIBS execinfo)
----------------
krytarowski wrote:
> brucem wrote:
> > This really should turn into a check so that we don't need this to be extended for every single OS that gets added.
> There is now support for CMake >= 3.0, which offers a builtin check for it.
I agree with previous comments - if we can convert this to a CMake built-in check, that would be ideal.


https://reviews.llvm.org/D23977





More information about the lldb-commits mailing list