[Lldb-commits] [PATCH] D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

[Zachary Turner via lldb-commits]

Also given that the reformat is going to happen today, I wonder if we
should wait until after it is complete to put in any more high risk changes.

On Tue, Sep 6, 2016 at 8:07 AM Pavel Labath via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

> labath requested changes to this revision.
> labath added a comment.
> This revision now requires changes to proceed.
>
> I have a couple of questions I'd like to be answered before this goes in.
> Apart from the inline comments, all my questions from the previous version
> of this commit still stand.
>
>
> ================
> Comment at:
> packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:5
> @@ +4,3 @@
> +
> +ifeq "$(ARCH)" "i386"
> +       CXXFLAGS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32
> ----------------
> This should not be necessary. Makefile.rules already correctly appends
> -m32 when needed. Maybe CFLAGS_EXTRAS would work instead (?)
>
> ================
> Comment at:
> packages/Python/lldbsuite/test/functionalities/register/register_command/TestRegisters.py:297
> @@ -294,4 +296,3 @@
>              for registerSet in registerSets:
> -                if 'advanced vector extensions' in
> registerSet.GetName().lower():
> -                    has_avx = True
> -                    break
> +                if registerSet.GetName():
> +                    if 'advanced vector extensions' in
> registerSet.GetName().lower():
> ----------------
> Do we want to allow a register set with no name? It looks like the root of
> the problem is elsewhere.
>
>
> https://reviews.llvm.org/D24255
>
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160906/cc8640ab/attachment.html>