[Lldb-commits] [PATCH] D23884: Add StructuredData unit tests; remove JSON parsing string copy

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 26 10:29:16 PDT 2016

tfiala added a comment.

In https://reviews.llvm.org/D23884#526419, @tfiala wrote:

> > Again, if we switch the parser over to use an llvm::StringRef then this make sense, otherwise it doesn't.
> I don't want to conflate this change with switching the parser over to a string ref.  The only reason I changed the entry to a const char* was to avoid creating a couple unnecessary temporaries.
> We can consider the parser conversion a separate logical change that can be done independently.

Greg and I talked about this a bit.

I'm going to reverse out the change to the JSON parsing signature, and just add a move-enabled one to avoid the temporary I was concerned about.


More information about the lldb-commits mailing list