[Lldb-commits] [PATCH] D23545: Minidump parsing

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 26 07:36:29 PDT 2016

zturner accepted this revision.
zturner added a reviewer: zturner.
This revision is now accepted and ready to land.

Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:60
@@ +59,3 @@
+    MinidumpParser parser(data_buf_sp, header, directory_map);
+    return llvm::Optional<MinidumpParser>(parser);
You can just write `return parser` here.  It's implicitly convertible to an `llvm::Optional<>`.

Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:65
@@ +64,3 @@
+                               const llvm::DenseMap<uint32_t, MinidumpLocationDescriptor> &directory_map)
+    : m_data_sp(data_buf_sp), m_header(header), m_directory_map(directory_map)
This isn't really a performance critical class, so it doesn't matter too much, but you could `std::move(directory_map)` to avoid the copy.


More information about the lldb-commits mailing list