[Lldb-commits] [PATCH] D23545: Minidump parsing

[Zachary Turner via lldb-commits]

I see.  Let me follow up with the breakpad developers to ask them about
that.  If you only have to support one endianness the code can be much
cleaner.

On Tue, Aug 16, 2016 at 9:44 AM Dimitar Vlahovski <dvlahovski at google.com>
wrote:

> dvlahovski added inline comments.
>
> ================
> Comment at: source/Plugins/Process/minidump/MinidumpTypes.cpp:31-35
> @@ +30,7 @@
> +    // the signature might be byte swapped
> +    data.SetByteOrder(lldb::eByteOrderBig);
> +    *offset -= 4;
> +    signature = data.GetU32(offset);
> +    if (signature == MINIDUMP_SIGNATURE)
> +        return true;
> +
> ----------------
> zturner wrote:
> > Why would this be true?  Is there a minidump specification somewhere
> that says that both big endian and little endian are valid byte orderings?
> I would expect that being a Microsoft created format, it should always be
> little endian, and if there is a file in big endian we can consider it
> corrupt.
> I didn't find anything in the MS documentation about the minidump's
> endianess.
> I am doing this because breakpad does this too:
> https://chromium.googlesource.com/breakpad/breakpad/+/master/src/processor/minidump.cc#4384
>
>
>
> https://reviews.llvm.org/D23545
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160816/faefc4d0/attachment.html>