[Lldb-commits] [PATCH] D23553: Move packet construction from GDBRemoteRegisterContext go the communication class

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 16 06:17:01 PDT 2016


labath added inline comments.

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:601
@@ -600,3 @@
-    
-                if (gdb_comm.SendPacketAndWaitForResponse(packet, packet_len, response, false) == GDBRemoteCommunication::PacketResult::Success)
-                {
----------------
The location of the duplicate `Send`. Also similar two cases in `WriteAllRegisterValues`.


https://reviews.llvm.org/D23553





More information about the lldb-commits mailing list