[Lldb-commits] [PATCH] D22950: Centralize all calls to select() into a single class so we always call select properly

[Jim Ingham via lldb-commits]

jingham added a subscriber: jingham.
jingham added a comment.

In https://reviews.llvm.org/D22950#500582, @emaste wrote:

> Testing now on FreeBSD. Do you have a sense of how many fds lldb might use in practice? For FreeBSD we can increase it from the default if necessary via
>
>   NOTES
>        The default size of FD_SETSIZE is currently 1024.  In order to accommo‐
>        date programs which might potentially use a larger number of open files
>        with select(), it is possible to increase this size by having the program
>        define FD_SETSIZE before the inclusion of any header which includes
>        <sys/types.h>.
>
>
> Also for future patch uploads would you include more context to make review easier (e.g. `git diff -U999` or `svn diff --diff-cmd=diff -x -U999`)?


This is a particular problem on OS X because we support debugging with the debug info in .o files, so for a complex project we could be opening lots of those files.  If you don't do that, then it's more like number of shared libraries a normal program will open.  That's unlikely to get to more than 1024.


https://reviews.llvm.org/D22950